[PATCH 0/9] various mainly pcf50633 resume improvements

Andy Green andy at openmoko.com
Sat Jun 14 08:27:57 CEST 2008

Hash: SHA1

Somebody in the thread at some point said:

| I like the improvements, but there appears to be an error somewhere. I'm
| getting wakeups from the GSM, but nothing from the pcf50633. How are
| interrupts generated? Are they edge or level triggered? somehow the work
| queue is hanging.

It's edge... maybe I know what this is.  Previously we gratuitously
called the workqueue function on resume, which clears the pending IRQ
status for sure.  But here, it isn't necessary: there is always a
pending real interrupt from PMU.  But then my SOP for making a resume is
hitting the power button.

It doesn't do any harm if we call the work directly and there is or is
not any pending interrupts, and the work is protected by mutex, so I
stuck it back in and updated andy branch with that and a couple of other
tiny fixes including little checkpatch stuff.

Despite we made some real progress in fact the whole suspend / resume
thing remains extremely fragile due to probably just one or two more
monsters in the deep shadows we never understood yet.  And they're the
kind of monsters that attack if you go hunting for them:
no_console_suspend on the kernel commandline kills resume the same way
as mdelay() in glamo suspend stuff, and equally with no real trace of
how or why it blew chunks.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list