[PATCH] fix-lis302dl-isr-lock.patch

Andy Green andy at openmoko.com
Mon Mar 31 18:49:23 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

| Isn't this common best practice for ISRs to lock the own interrupt (and

I'm a bit wary of doing this with the edge-triggered interrupts on this
platform.  Some months ago one or another of the drivers I worked on
(maybe this one in its original form) had this edge-triggered stuff and
used that specific interrupt disable code.  It didn't work well and
under load an edge would missed if it came during the disabled period.
The result was a permanently stuck low interrupt line that never got
acknowledged.

When I changed the code to not disable the specific interrupt itself
then the problem went away.  I never pinned down where it came from.

| possibly lower prioritized interrupts of other devices (AccMeter2)) at
very
| beginning of ISR, prior to resetting it and handling event. At very
end of

Well we added a bit of latency to other interrupts at low probability.
But this code will definitely do the intended task and hopefully solves
an issue holding up production test today.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkfxFggACgkQOjLpvpq7dMqYsQCfegkEf2JG3FXbEddtyeVCGbiS
YvUAnivz1/1a758+Te6tHMjTaXMH3Pa1
=sxj/
-----END PGP SIGNATURE-----




More information about the openmoko-kernel mailing list