(GTA02, u-boot) wait-for-power patch update

Werner Almesberger werner at openmoko.org
Mon Mar 31 19:12:46 CEST 2008


Andy Green wrote:
> Seems fine to move and invert that if ().

Great, thanks !

> Shame to delay video init, I tried hard to get that as early as possible.

Yeah, but it actually gives nice feedback when the LCM turns on the
moment when you can release the POWER button. (That protection
against accidentally powering on wasn't in GTA02's u-boot when you
wrote the video init, so you couldn't have noticed that fortunate
coincidence.)

By the way, I'm having second thoughts about the voltage check in
the wait for power logic. So I've backed it out for now.

I've added wait-for-power.patch in revision 4276. I've also removed
nor-default-env.patch, whose functionality is now provided by the
preboot-override for the environment.

Finally, I added better LED logic so that it can be used as a
power-up indicator. (The code for this was always there, it just
didn't work properly.)

Phew. Things now make a lot more sense :-)

- Werner

----------------------------------- Changes -----------------------------------

Change startup behaviour such that the LCM backlight serves as an indicator
that POWER can be released. Also flash the red LED briefly when powering up.
Doing this sensibly required adding a work-around for the GTA02v5 LED bug,
which is in gpb-shadow.patch

series, nor-default-env.patch:
- we have a better way to accomplish what nor-default-env.patch was intended to
  do. Removed it.

series, wait-for-power-DONTUSE.patch:
- renamed wait-for-power-DONTUSE.patch to wait-for-power.patch and activated it
  in "series"
- board/neo1973/gta02/gta02.c (wait_for_power): removed minimum battery voltage
  condition
- board/neo1973/gta02/gta02.c (board_late_init): activate the red LED for 20ms,
  while the vibrator is running (note: this only has a visible effect on
  GTA02v6 and above)

series, gpb-shadow.patch:
- board/neo1973/gta02/gta02.c (neo1973_vibrator, neo1973_led): shadow the LED
  state to work around GTA02v5 bug




More information about the openmoko-kernel mailing list