Bug in keyboard driver

Sean McNeil sean at mcneil.com
Thu May 8 09:08:21 CEST 2008

the KEY_PHONE is backwards. It returns up when pushed and down when 
released. The following change fixes it:

 static irqreturn_t neo1973kbd_aux_irq(int irq, void *dev_id)
        struct neo1973kbd *neo1973kbd_data = dev_id;
-       int key_pressed = !gpio_get_value(irq_to_gpio(irq));
+       int key_pressed = !!gpio_get_value(irq_to_gpio(irq));
        input_report_key(neo1973kbd_data->input, KEY_PHONE, key_pressed);

More information about the openmoko-kernel mailing list