Bug in keyboard driver
Andy Green
andy at openmoko.com
Thu May 8 10:27:16 CEST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Somebody in the thread at some point said:
| the KEY_PHONE is backwards. It returns up when pushed and down when
| released. The following change fixes it:
|
| static irqreturn_t neo1973kbd_aux_irq(int irq, void *dev_id)
| {
| struct neo1973kbd *neo1973kbd_data = dev_id;
|
| - int key_pressed = !gpio_get_value(irq_to_gpio(irq));
| + int key_pressed = !!gpio_get_value(irq_to_gpio(irq));
| input_report_key(neo1973kbd_data->input, KEY_PHONE, key_pressed);
| input_sync(neo1973kbd_data->input);
Thanks for the nice find -- I patchified it, signed it off by you and
added it to stable / andy / andy-tracking.
- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkgiuWQACgkQOjLpvpq7dMoQwACZAb5G7wDJTzobXv190W/pwOfx
AwQAniOtkpkpSamd06WwezRCiZKFEaiC
=oU3p
-----END PGP SIGNATURE-----
More information about the openmoko-kernel
mailing list