andy at openmoko.com
Thu May 8 14:28:33 CEST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
| On Thu, May 08, 2008 at 11:37:23AM +0100, Andy Green wrote:
|> Our Alsa stuff has gone through the alsa lists into mainline thanks to
|> Graeme if I understood it, which was nice to see, there were one or two
|> things to clean there but basically it replaced some of our patches.
|> Nice treat.
| The GTA02 stuff is not merged with Linus or with the main ALSA tree - it
| relies on asm/arch/gta02.h which hasn't been merged yet so it won't build.
| It's sitting in the ASoC tree, though. Otherwise you should be down to
| only carrying gta02-sound-bandaid.patch I think?
Yeah I would have noticed if it had all gone :-) "Our Alsa stuff" I
meant is the stuff I saw sail by on the alsa lists.
| FWIW the ALSA maintainers reject patchs that aren't checkpatch clean so
| it'd be helpful if you could be strict about that when accepting patches
| for there at least. Greame and myself have cleaned up the existing ASoC
| code so hopefully this shouldn't be too much work but it's worth bearing
| in mind. Some other subsystems have similar policies.
Yes I had my behind singed myself by linux-wireless. I don't think
checkpatch is too much to ask either. But some people get dismayed if
asked to reissue, I think it can also be good for "morale reasons" to
accept violating patches so long as they are accompanied by a patch on
top to clean them when they're committed. Still no argument we need to
align what we are doing to normal rules upstream like Signed-off-by and
checkpatch (sparse can maybe wait).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel