[PATCH 1/6] various janitorial work on the pcf50633.c

Holger Freyther zecke at openmoko.org
Fri May 9 23:34:08 CEST 2008

From 4ce6d616695a65816e3449c887e0fd131c93ccdd Mon Sep 17 00:00:00 2001
From: Holger Freyther <zecke at openmoko.org>
Date: Thu, 8 May 2008 15:41:15 +0200
Subject: [PATCH] Explain why we want SECOND to kick.
     We do not mask the SECOND interrupt to make sure that we get
     a interrupt at the beginning. We use this for the coldplug_done
     So pcf->flags and INT1M is out of sync at the beginning but after the
     first SECOND interrupt it will be put into sync.

Signed-Off-By: Holger Freyther <zecke at openmoko.org>
 drivers/i2c/chips/pcf50633.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/chips/pcf50633.c b/drivers/i2c/chips/pcf50633.c
index 09d5cfd..10f4eb3 100644
--- a/drivers/i2c/chips/pcf50633.c
+++ b/drivers/i2c/chips/pcf50633.c
@@ -1744,7 +1744,8 @@ static int pcf50633_detect(struct i2c_adapter *adapter, 
int address, int kind)
 		goto exit_sysfs;
 	/* configure interrupt mask */
-	reg_write(data, PCF50633_REG_INT1M, 0x00); /* we want SECOND to kick */
+	/* we want SECOND to kick for the coldplug initialisation */
+	reg_write(data, PCF50633_REG_INT1M, 0x00);
 	reg_write(data, PCF50633_REG_INT2M, 0x00);
 	reg_write(data, PCF50633_REG_INT3M, 0x00);
 	reg_write(data, PCF50633_REG_INT4M, 0x00);

More information about the openmoko-kernel mailing list