[PATCH 4/6] various janitorial work on the pcf50633.c
andy at openmoko.com
Sat May 10 14:55:05 CEST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
| On Saturday 10 May 2008 14:06:18 Wolfgang Spraul wrote:
|> We ship only with HDQ batteries, that's correct.
|> But people may well have old GTA01 batteries, or use compatible Nokia
|> BL-4C/5C/6C batteries, or no-name replacements for those.
|> Our battery driver and infrastructure should be as robust as possible.
| The driver is robust. Currently "cat /proc/apm" is returning -1 for
| batteries, after the patch a sane number is reported (good for the
| Regarding "acme replacement batteries". They will charge, "cat /proc/apm"
| will return a wrong voltage number, but we don't know the battery
Which changes with age, and if the battery happens to be getting charged
at the time we look. That's why we're on HDQ smart battery now.
| these batteries anyway. The best I can think of is to have a sysfs file
| somewhere to switch between ADC and HDQ...and move this prob' to
Under these circumstances we should refer to the specification and its
detailed description of power behaviours, which batteries we target and
"moving it to userspace" is just moving the person Wolfgang will moan at
about it not working, a valid answer to the conundrum I admit: but a
better one is to just not support reporting a bogus battery life
estimate with a battery we don't ship or even know what it is.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel