minor problem with LCD

Andy Green andy at openmoko.com
Sun May 11 08:48:01 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| Looking at wrong register to see if the LCD is turned off?
|
| diff --git a/drivers/i2c/chips/pcf50633.c b/drivers/i2c/chips/pcf50633.c
| index 7ac466b..45ba5bf 100644
| --- a/drivers/i2c/chips/pcf50633.c
| +++ b/drivers/i2c/chips/pcf50633.c
| @@ -1469,7 +1469,7 @@ static int pcf50633bl_get_intensity(struct
| backlight_device *bd)
|     struct pcf50633_data *pcf = bl_get_data(bd);
|     int intensity = reg_read(pcf, PCF50633_REG_LEDOUT) << 2;
|
| -    if (!(reg_read(pcf, PCF50633_REG_LEDOUT) & 1))
| +    if (!(reg_read(pcf, PCF50633_REG_LEDENA) & 1))

Well spotted, sir.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkgmlqEACgkQOjLpvpq7dMolhgCglO1W1OQ0iiJ37JcjKQ1OArZ/
2CYAnj/JHoXnZgHSXlELrbyL7W2GNtXv
=u5WZ
-----END PGP SIGNATURE-----




More information about the openmoko-kernel mailing list