RFC: GSM flowcontrol handling, GTA01 and GTA02
mwester at dls.net
Wed May 28 06:31:35 CEST 2008
Andy Green wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Somebody in the thread at some point said:
> | Patch tarball: http://moko.mwester.net/mw09_kernel_patches.tgz
> OK I stuck these into andy branch in git -- compiles OK but I didn't
> test gsm performance with this lot in.
> Thanks for the work.
Thanks for adding these to the branch!
> Some meta-comments about the patchset rather than the patches
I'd like to plead ignorance -- but I can't. I was just being sloppy and didn't
(yet) have the patches in the form they should have been. To be honest, I was
expecting a few go-rounds of discussions and changes before they would be committed!
Next time, please feel free to throw them back at me to get them fixed up; you
shouldn't have to spend your time on obvious style issues :-)
> Despite these comments I really appreciate the work you have put in and
> stuck this first version of the patches on the "andy" branch straight away.
"First version" is the correct characterization. There are some technical
changes that I think we need to make already (I'll hold back to see what other
comments might be first).
And there is an organization issue I'd like comments on -- I think if we pull
the GSM IRQ handler out of mach-gta0x.c and into neo1973_pm_gsm.c, it'll clean
up some things. Also, perhaps some of this stuff will be more palatable if it
were enabled via Kconfig.
I agree with the general principle on keeping GTA-specific things out of the
serial driver... but the problem is that issues of one sort or another keep
dragging me back into that code. Dealing with some of the GSM issues and
requirements from code outside the serial driver is rather like repairing one's
roof -- from across the street :-) If there are generic ways we can solve
problems instead, we should definitely explore those ways.
Thanks again for your efforts on this, and the next patches will at least be
style-checked correctly and have the correct attributions.
> - -Andy
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
> -----END PGP SIGNATURE-----
More information about the openmoko-kernel