[PATCH] fix root cause of NAND trouble

Andy Green andy at openmoko.com
Sun Nov 2 01:26:12 CET 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| Ben Dooks wrote:
|> My only comment would be
|> that a slightly better solution would be to do:
|
| Oh, that's much better, thanks ! I hadn't realized at first that
| once could read the FIFO one byte at a time.
|
| The revised patch is below.

|  	readsl(info->regs + S3C2440_NFDATA, buf, len / 4);
| +	for (i = 0; i != (len & 3); i++)
| +		ptr[i] = readb(info->regs + S3C2440_NFDATA);

Great, it's even endian-clean.  I'll replace the other one in
stable-tracking with this then until a rebase will make it unnecessary.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkkM86QACgkQOjLpvpq7dMq7rwCfbbfJGyYBjPscSb/JN8osY0BT
XLMAnivEixkY4A6L4wVtkhPg23Bb9I67
=xPm0
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list