[PATCH] fix root cause of NAND trouble

Ben Dooks ben-linux at fluff.org
Mon Nov 3 15:14:07 CET 2008

On Sun, Nov 02, 2008 at 02:28:46PM -0200, Werner Almesberger wrote:
> Ben Dooks wrote:
> > as well as that, it looks like the /4 in readsl() is trying to round
> > up, probably changing it to
> > 
> > 	readsl(buf, data, len >> 2);
> > 
> > is a much better idea.
> I'll have a look at this in a bit. I think what's going on with the
> /4 is that gcc tries to handle the case that the (signed) length is
> negative. Turning it into >> 2 indeed shortens the code by 12 bytes.
> Good. When I saw all these divisions, I felt something in my stomach
> contract a little. Now you explained why :-)

do you have a new version of the patch to review? this is something
we should probably get merged before 2.6.28 is out.


Q:      What's a light-year?
A:      One-third less calories than a regular year.

More information about the openmoko-kernel mailing list