[UPSTREAM 0/2] pcf50633 changes
balajirrao at openmoko.org
Mon Nov 17 07:11:42 CET 2008
On Sun, Nov 16, 2008 at 08:59:37PM +0000, Andy Green wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Somebody in the thread at some point said:
> | Somebody in the thread at some point said:
> | | Hi,
> | |
> | |
> | | Here's a pcf50633 driver rewrite to use the MFD model. This has resulted
> | | in pretty large number of changes.
> | Some warnings came out:
> | drivers/mfd/pcf50633-core.c:119: warning: initialization from
> | incompatible pointer type
> | drivers/mfd/pcf50633-core.c: In function ‘pcf50633_suspend’:
> | drivers/mfd/pcf50633-core.c:266: warning: unused variable ‘ret’
> | drivers/mfd/pcf50633-mbc.c:88: warning: initialization from incompatible
> | pointer type
> drivers/i2c/built-in.o: In function `pcf50633_reg_clear_bits':
> multiple definition of `pcf50633_reg_clear_bits'
> first defined here
> Should this patchset have removed drivers/i2c/chips/pcf50633.c?
It doesn't. The problem is, I forgot to remove CONFIG_SENSORS_PCF50633
from the defconfig. Will update.
More information about the openmoko-kernel