[UPSTREAM 0/2] pcf50633 changes

Balaji Rao balajirrao at openmoko.org
Mon Nov 17 07:14:05 CET 2008


On Sun, Nov 16, 2008 at 09:21:10PM +0000, Andy Green wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Somebody in the thread at some point said:
> | Somebody in the thread at some point said:
> | | Somebody in the thread at some point said:
> | | | Hi,
> | | |
> | | |
> | | | Here's a pcf50633 driver rewrite to use the MFD model. This has
> | resulted
> | | | in pretty large number of changes.
> | |
> | | Some warnings came out:
> | |
> | | drivers/mfd/pcf50633-core.c:119: warning: initialization from
> | | incompatible pointer type
> | |
> | | drivers/mfd/pcf50633-core.c: In function pcf50633_suspend:
> | |
> | | drivers/mfd/pcf50633-core.c:266: warning: unused variable ret
> | |
> | | drivers/mfd/pcf50633-mbc.c:88: warning: initialization from incompatible
> | | pointer type
> |
> | drivers/i2c/built-in.o: In function `pcf50633_reg_clear_bits':
> | /projects/openmoko/kernel/linux-2.6/drivers/i2c/chips/pcf50633.c:174:
> | multiple definition of `pcf50633_reg_clear_bits'
> |
> drivers/mfd/built-in.o:/projects/openmoko/kernel/linux-2.6/drivers/mfd/pcf50633-core.c:67:
>
> |
> | first defined here
> |
> | Should this patchset have removed drivers/i2c/chips/pcf50633.c?
>
> Also:
>
> ./include/linux/rtc/pcf50633.h
>
> still seems to be missing... all these are based on updated
> balaji-tracking rather than what was posted here, hopefully they are the
> same and not caused by other stuff on andy-tracking either.
>

It's removed now. It's replaced by include/linux/mfd/pcf50633/rtc.h.

But I've updated the earlier patch to add the missing
include.

	- Balaji



More information about the openmoko-kernel mailing list