[UPSTREAM 0/2] pcf50633 changes

Andy Green andy at openmoko.com
Mon Nov 17 09:22:32 CET 2008

Hash: SHA1

Somebody in the thread at some point said:
| Werner Almesberger wrote:
|> Mike (mwester) wrote:
|>> I'm rather concerned; it's all too easy to have this functionality get
|>> lost in the shuffle if it's not implemented up front.
|> Hmm, in the last few hours, you, Andy, and I have mentioned it.
|> Somehow that doesn't look like amnesia ;-)
| I was, of course, referring implementing this functionality as opposed
| to discussing it.
|>> "feels wrong" -- the button push was to wake up the hardware and nothing
|>> more; since the user is not intending to signal anything to user space,
|> The question in my mind: is this necessarily true ?
|> If POWER gets used for other purposes in the handling of the device
|> as well, it seems plausible that it gets pressed also when the user
|> is not aware that the device has just suspended, in which case the
|> event should not be ignored by the kernel.
| I give up.

Hopefully we convince Balaji these two things have a use in pcf50633,
otherwise we will patch them in on top via mach-gta02.c.

Balaji's problem is he is the guy that has to sell each of these things
upstream, so it's right from his side he pushes back on stuff that
sounds like it will create trouble -- and if you're selling a PMU driver
upstream, input event swallowing and reset on button hold are both
things that will get queried during review.  I think we have enough
story on both that they are generic and belong in there.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list