[PATCH] [GTA02] Fix compilation of neo1973_pm_gsm if no GTA02
laforge at openmoko.org
Wed Nov 19 03:53:23 CET 2008
On Tue, Nov 18, 2008 at 04:00:43PM -0200, Werner Almesberger wrote:
> Harald Welte wrote:
> > If compiling a kernel with just GTA01 support, we have to
> > make sure we don't include the GTA02 specific bits in this driver.
> This is backwards. We just threw these #ifdefs out.
Well, it's a question of point-of-view. Why should the compiled kernel
module contain code for a machine type which the kernel is compile-time
configured to not support? Is seving .text size not worth a couple of #ifdefs?
> What specific problem did you encounter with the code as it currently
> is ?
It doesn't compile if you don't have CONFIG_MACH_GTA02 in your .config
Probably related to some missing #defines in the include files at this time.
- Harald Welte <laforge at openmoko.org> http://openmoko.org/
Software for the world's first truly open Free Software mobile phone
More information about the openmoko-kernel