[PATCH 0/3] Qi booting control from rootfs

Micael Henriksson micael.h at gmail.com
Tue Nov 25 01:53:34 CET 2008


On Sun, Nov 23, 2008 at 9:44 PM, Andy Green <andy at openmoko.com> wrote:
> These patches allow some control over Qi booting actions
> from the rootfs containing the kernel being considered.
>
> /boot/noboot-<device>, eg, /boot/noboot-GTA02 if present
> will force the rootfs to be not considered for booting.

Hi...

I didn't see this at first, but this change will make booting from
anything but EXT2 (i.e. NAND for now) always fail...

When trying to see if the noboot-<device> file exists, read_file()
will always return >0 if the file system is NAND and the block read
was ok and then skip the NAND partition...

from phase2.c:
		/* does he want us to skip this? */

		if (read_file(this_board->noboot, kernel_dram, 512) >= 0) {
			puts("    (Skipping on finding ");
			puts(this_board->noboot);
			puts(")\n");
			this_kernel = &this_board->kernel_source[kernel++];
			continue;
		}

I was thinking about making a quick patch (adding a condition
"this_kernel->filesystem != FS_RAW"), but run in to the "problem" of
making a good solution.. :/
It's not nice to let the otherwise generic kernel loading code
suddenly check which file system the kernel is on..

Andy.. got any nice idé?

Cheers
/Micael



More information about the openmoko-kernel mailing list