[PATCH] fix rfkill initialization value - use this instead
sean at mcneil.com
Fri Nov 28 08:16:57 CET 2008
I apologize for having to use you to debug this. I'm going to patch
jffs2 here to stop being so chatty. In the meantime, I don't see
anything obvious about the device name and why it is not set. Can you
try this patch?
Nelson Castillo wrote:
> On Thu, Nov 27, 2008 at 11:01 PM, Sean McNeil <sean at mcneil.com> wrote:
>> Really shouldn't have any compiler warnings. This includes a check on the
>> rfkill_register which is marked as must check. Please use this patch instead
>> for clean compilation.
>> Sean McNeil wrote:
>>> It turns out the code I used for reference was setting an invalid initial
>>> value for the state. Setting it to the off state should prevent the warning
>>> trace seen by Werner. I didn't see it as my dmesg buffer is flooded with
>>> other messages, so I can't verify it is gone either.
> Hello Sean.
> Before the patch I would get:
> [21474539.315000] SD power -> 2700mV
> [21474539.335000] ------------[ cut here ]------------
> [21474539.340000] WARNING: at net/rfkill/rfkill.c:752
> [21474539.345000] rfkill: attempt to register a badly initialized rfkill struct
> And after the patch I get:
> [21474539.305000] SD power -> 2700mV
> [21474539.365000] ��@��@�8BB�x : GTA02 Set PCF50633 LDO4 = 3200
> [21474539.375000] neo1973-pm-host neo1973-pm-host.0: starting
> I tried twice.
> Is it OK?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 947 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20081128/6c439bca/attachment.patch
More information about the openmoko-kernel