[PATCH] fix rfkill initialization value - use this instead

Sean McNeil sean at mcneil.com
Fri Nov 28 09:46:38 CET 2008

Well, I get a ton of messages without this:

diff --git a/fs/jffs2/scan.c b/fs/jffs2/scan.c
index 1d437de..22ab420 100644
--- a/fs/jffs2/scan.c
+++ b/fs/jffs2/scan.c
@@ -647,8 +647,8 @@ scan_more:
 			inbuf_ofs = ofs - buf_ofs;
 			while (inbuf_ofs < scan_end) {
 				if (unlikely(*(uint32_t *)(&buf[inbuf_ofs]) != 0xffffffff)) {
-					printk(KERN_WARNING "Empty flash at 0x%08x ends at 0x%08x\n",
-					       empty_start, ofs);
+					D1(printk(KERN_WARNING "Empty flash at 0x%08x ends at 0x%08x\n",
+					       empty_start, ofs));
 					if ((err = jffs2_scan_dirty_space(c, jeb, ofs-empty_start)))
 						return err;
 					goto scan_more;

Werner Almesberger wrote:
> Sean McNeil wrote:
>> I'm going to patch jffs2 here to stop being so chatty.
> By the way, why is this ? A chatty JFFS2 usually means that there's
> something much more serious amiss.
> If you're having ECC problems, you may want to check that your kernel
> has the NAND non-word read fix, commit
> 9bcafb0339e3d3bd1a7b1f765a954c5427e11bce
> If it does and you still get lots of errors, then your rootfs image
> may have been written with the wrong ECC algorithm. In this case,
> you'll get bit corruption (detected by JFFS2 as a CRC error) whenever
> you read a block where the difference between the stored and the
> calculated ECC suggests a "correctable" single-bit error.
> In this case, the only real remedy is to throw away the corrupt
> rootfs and to flash a new image, or to completely sidestep the
> problem and use a rootfs on microSD instead of NAND.
> - Werner

More information about the openmoko-kernel mailing list