[PATCH 05/11] ALSA: make WM8753 driver a new-style I2C driver
broonie at opensource.wolfsonmicro.com
Wed Oct 1 18:43:32 CEST 2008
On Wed, Oct 01, 2008 at 05:22:33PM +0100, Andy Green wrote:
> I went and fetched Jean's patch, it did apply after some meddling
> (indicating there are other patches on wm8753 stuff not in kernel.org
> HEAD yet), but trying to fold it into the other patches from Jonas
> seemed a step too far for me.
There's a series of changes - Jean changed the external amp in the GTA01
separately from WM8753 and there's at least one followup from me due to
a couple of build failures in GTA01. git log on the codec and GTA01
drivers should show everything. There's other general ASoC API updates
mixed in there, though.
> For now I guess we will take Jonas' stuff and rebase it out when Jean's
> accepted stuff comes in from upstream, it's a headache either way.
TBH I'm not clear what benefit there is from doing these changes in the
OpenMoko tree is - the net effect of the two registration APIs is the
same, it should just be a code cleanup change. If there were an
immediate benefit from doing the conversion or if it hadn't yet been
done upstream and could therefore be pushed upstream it'd make sense to
me but that's not the case here.
Note that this doesn't apply to the reordering of the scenario setup
which is a straight bugfix independant of the I2C API changes (ASoC got
better at pointing out when stuff goes wrong).
More information about the openmoko-kernel