preparing pcf50633 for upstream

Andy Green andy at openmoko.com
Wed Oct 1 21:14:04 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| Balaji Rao wrote:
|> Hi,
|>
|> I've managed to eliminate pcf50633_global and thus removed the
|> "one-device" restriction.
|>
|> With that, the apm emulation code - apm_get_battery_status has to be
|> moved out. I think mach-gta02.c is a good place. What do you say ?

This is pcf50633_get_power_status?  It does a pcf50633 register read in
there.  Or is it something else?

| Is the apm emulation even used? I didn't see where it was helpful. Maybe
| dbus uses it?

I think something uses it, Carsten was saying that because they do "apm
- -s" to suspend qpe gets a chance to sit on the intention to suspend
"before it reaches the kernel".

Let's keep resisting the urge to change stuff at the same time as the
upstream work unless we see we really have to, there is going to be
quite enough risk and difficulty just from the necessary changes.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkjjy/UACgkQOjLpvpq7dMrvVgCfcFed8MkHxY4vP6yj2TXY7hpt
etIAnRcwrNhNYVrO/1wvcuFRCmRjHMkp
=9keH
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list