preparing pcf50633 for upstream
andy at openmoko.com
Wed Oct 1 21:51:51 CEST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
|> This is pcf50633_get_power_status? It does a pcf50633 register read
|> in there. Or is it something else?
| Yes, but it needs pc50633_global. I was thinking if we could change
Got your point now, see the problem.
| pcf50633_get_power_status to take a struct pcf50633_data. This would be
| function to report power status in "apm style". And the
| apm_get_power_status callback itself could reside in mach_gta02.c
It sounds right about the callback in mach_gta02.c because in
./include/linux/apm-emulation.h it does say about struct apm_power_info
''* This structure gets filled in by the machine specific 'get_power_status'
~ * implementation. Any fields which are not set default to a safe
But I didn't quite see the idea about delivering struct pcf50633_data *
to the pcf50633_get_power from mach_gta02.c without a global somewhere?
| About the apm_queue_event, could we just surround it with a check for
| apm emulation and leave it alone ?
Yes it would be good to make a pcf50633_apm_queue_event() or something
to hold that check in one place and change all the apm_queue_event() to
go there. You could also make it conditionally compiled simply then
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel