[PATCH] Fix build with no CONFIG_MMC.

andrzej zaborowski balrogg at gmail.com
Thu Oct 2 14:00:14 CEST 2008

On 02/10/2008, Mike (mwester) <mwester at dls.net> wrote:
> Thomas White wrote:
>  > Andy Green <andy at openmoko.com> wrote:
>  >
>  >> Somebody in the thread at some point said:
>  >>
>  >>> I hit this when updating to 2.6.26.  Also if CONFIG_MMC is enabled
>  >>> this patch converts this horrible horrible hack into a horrible
>  >>> hack by using dev->resume() (untested).
>  >> Thanks for that, it is much neater.  Sent it on to stable.
>  >
>  > I find that this patch causes resume not to work, reproducibly, on my
>  > GTA02.  That is to say:  I was trying to build a kernel from the tip of
>  > the 'stable' branch and ran into  problems (unresponsive black screen
>  > when trying to resume via the power button). I did a 'git bisect' and
>  > isolated it to this commit, and reverting this commit (only) caused the
>  > problem to go away for me.
>  >
>  > Is it possible that "dev->resume()" is not properly initialised somehow?
> I duplicated that code for the GTA01, so at one point apparently I
>  understood what that stuff was doing.  Today I'm lost in dev
>  structures... but as near as I can see, the problem is that the dev
>  structure referred to by the argument to gta02_glamo_mci_suspending() is
>  not the dev structure containing the pointer to glamo_mci_resume(). In
>  other words, (void *)dev->dev.driver->resume != glamo_mci_resume; it
>  points to some other resume handler altogether.

Ah, I was fearing it might not be the same one (and as mentioned had
not tested it).  The func is probably called by the parent of the
glamo_mci which is the glamo itself, so we're probably resuming the
glamo two times and not resuming the mci.  This can be fixed in
drivers/mfd/glamo but it's still a hack.


More information about the openmoko-kernel mailing list