[PATCH 02/11] Drop FIQ dependency for GTA01 configuration.
jonas.bonn at gmail.com
Fri Oct 3 08:55:00 CEST 2008
> Isn't this select needed on GTA02? I don't know if maybe something like
> - select S3C2440_C_FIQ
> + select S3C2440_C_FIQ if MACH_NEO1973_GTA02
> would be better?
Agreed, this would be better. I can make this change.
> I don't think this is a good idea. If machine_is_neo1973_gta02()
> returns false, this code will be compiled out anyway. So you are
> adding redundancy to gain what? Faster compile time?
> The same comment applies to all the other places where you wrap
> conditional blocks like this.
No, the code does not get "compiled" out... optimized out perhaps, but
the code still gets compiled and all the symbols between the braces
need to be defined.
Honestly, I just needed to get the thing compiling when I #ifdef'ed
out the code... it's obvious that nobody else has ever tried compiling
without the GTA02 option set. If there's a better way, then I'm open
to changes, but for my purposes (whose aim was to get the sound
working on my Neo), this was sufficient. I will look over this patch
again this weekend.
More information about the openmoko-kernel