[PATCH 02/11] Drop FIQ dependency for GTA01 configuration.
andy at openmoko.com
Fri Oct 3 10:08:41 CEST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Jonas Bonn wrote:
> No, the code does not get "compiled" out... optimized out perhaps, but
> the code still gets compiled and all the symbols between the braces
> need to be defined.
> Honestly, I just needed to get the thing compiling when I #ifdef'ed
> out the code... it's obvious that nobody else has ever tried compiling
Generally speaking, it would be cool if we gradually moved to people
providing patches on top with their comments if the changes are simple
at least. It's probably quicker for the commenter, shows exactly the
intention so less explanation is needed, and gives me something to apply
if it makes sense.
It's hard enough doing the work behind the original patch making it
perfect in one go is often out of reach, that is fine. We are way ahead
of the game compared to having nothing and these issues are small.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel