[UPSTREAM - RFC] pcf50633_use_regulator_api.patch
Werner Almesberger
werner at openmoko.org
Wed Oct 8 18:05:36 CEST 2008
Mark Brown wrote:
> > +#define PCF50633_REGULATOR(_name, _id) \
> > + { \
> > + .name = _name, .id = _id, .ops = &pcf50633_reg_ops, \
> > + .irq = 1, .type = REGULATOR_VOLTAGE, \
> > + .owner = THIS_MODULE, \
> > + }
One small nitpick: if you set only one item per line, reviewers
don't need Mark's keen eyesight to spot such thing :-)
- Werner
More information about the openmoko-kernel
mailing list