[UPSTREAM - RFC] pm_bt_use_regulator_api.patch

Andy Green andy at openmoko.com
Wed Oct 8 18:07:31 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Balaji Rao wrote:
> On Wed, 08 Oct 2008 16:18:32 +0100
> Andy Green <andy at openmoko.com> wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Balaji Rao wrote:
>>> pm_bt_use_regulator_api.patch
>>>
>>> Use regulator API for powering on/off the BT device.
>>> +	.voltage_supply = "BT_3V2",
>> There's a conflict between "BT_3V2" here and "bt_3v2" used in
>> pcf50633_platform_data?
>>
> 
> The voltage rails pcf50633_platform_data are not used at all. I think
> we can get rid of it when the complete transition is over ?

No problem then.

> All those should be defined as machine constraints with supplies
> matched against devices. Since we are using only hcldo, ldo4 and 5,
> I've just added constraints for those.
> 
> Anyway we can probably tackle this later as the main focus now is to
> cleanup pcf50633 driver. What do you say ?

Fine, just looked like they were trying to match up.

So far it boots fine and I didn't get any further yet due to my own
troubles with FIQ, which are half-solved, config for FTRACE that I
enabled actually adds function tracing code even to __attribute__
((naked)) functions...

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkjs2sMACgkQOjLpvpq7dMqPtwCeIP0hY71mn08JhKZKn4UZ2Q4N
nwIAn3XXWnQVb3JJDUYnjHG5WpJpUgQI
=Lj5y
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list