[UPSTREAM - RFC] pcf50633_use_regulator_api.patch
laforge at openmoko.org
Thu Oct 9 00:15:07 CEST 2008
first of all thanks for all your work.
On Wed, Oct 08, 2008 at 07:38:45PM +0530, Balaji Rao wrote:
I don't really like the split betwee the i2c-pcf5633 part and the regulator
part. It means that you need to publicly expose/export a number of low level
register read/write/set/clearbit functions, plus put the entire register
definitions into the public linux/pcf50633.h file.
It is usually not a good idea to expose that many internal details to the
kernel. Either you just put the two files into one driver by directly linking
multiple .c/.o files into one .ko, or you find some other way how to find
a high-level API between the two drivers.
I personally think putting the i2c and the regulator bits together is a good
- Harald Welte <laforge at openmoko.org> http://openmoko.org/
Software for the world's first truly open Free Software mobile phone
More information about the openmoko-kernel