[UPSTREAM - RFC] pm_bt_use_regulator_api.patch

Balaji Rao balaji at raobalaji.com
Thu Oct 9 04:00:48 CEST 2008

On Wed, 8 Oct 2008 18:46:56 -0200
Werner Almesberger <werner at openmoko.org> wrote:

> Andy Green wrote:
> > Balaji, I would just ignore the cosmetic naming stuff.
> It's not just cosmetic - seeing items that call themselves gta01_foo
> but are not gta01-specific make the code very confusing to read,
> because they implicitly suggest that this is different or doesn't
> exist for gta02. (And yes, we have a bad precedent in the form of
> "2410". It's all about conventions in the end.)
> The good thing is that these changes are generally well-contained.
> Anyway, this is a different driver, whose time for complete cleanup
> hasn't come yet.

Yes! And it looks like it's quite a mess. There's some time before I
need to start worrying about it :)

	- Balaji

More information about the openmoko-kernel mailing list