[PATCH] Config: Ifdef cleanups

Werner Almesberger werner at openmoko.org
Sun Oct 12 00:35:37 CEST 2008


Jonas Bonn wrote:
> This patch removes a large number of #ifdefs that switch on machine
> model.

Wow, amazing !

> +	if (!ret) {
> +		return strlcpy(buf, "0\n", 3);
> +	} else {
> +		return strlcpy(buf, "1\n", 3);
> +	}

Hmm, this use of strlcpy may be something we want to get rid of as well.
It may make the copy marginally more efficient, but it also introduces
the risk of accidently mismatching the two arguments. Anyway, that's a
change for later consideration.

Thanks ! Thumbs up from me.

- Werner



More information about the openmoko-kernel mailing list