[PATCH] [GTA02]: Config fix for building without GTA01

Jonas Bonn jonas.bonn at gmail.com
Sun Oct 12 00:50:40 CEST 2008

On Sun, Oct 12, 2008 at 12:18 AM, Werner Almesberger
<werner at openmoko.org> wrote:
> Jonas Bonn wrote:
>> The option MACH_NEO1973 previously was set only when GTA01 was selected.
>> As the FIQ C option is dependent on this option as well, we set it for
>> the GTA02 case as well.
> Hmm, I can't see the dependency :-( Do you mean a Kconfig-level
> dependency, i.e., for LEDS_NEO1973_VIBRATOR or S3C2440_C_FIQ ?

Sorry, maybe I wasn't clear enough.  It's this:

Symbol: S3C2440_C_FIQ [=n]
  Prompt: FIQ ISR support in C
   Defined at arch/arm/mach-s3c2440/Kconfig:25
   Depends on: ARCH_S3C2410
     -> System Type
   Selects: FIQ
   Selected by: LEDS_NEO1973_VIBRATOR && NEW_LEDS && LEDS_CLASS &&
MACH_NEO1973 && MACH_NEO1973_GTA02

S3C2440_C_FIQ depends on MACH_NEO1973 which was previously only set
when MACH_NEO1973_GTA01 was selected.  This is nonsense, of course,
and I'm not sure this fix is really the right one, but it makes things
build with the configurations we have today.  Good enough for now, I
think, but it should be revisited at a later date.


More information about the openmoko-kernel mailing list