[PATCH] [GTA02]: Config fix for building without GTA01

Werner Almesberger werner at openmoko.org
Sun Oct 12 00:53:12 CEST 2008

By the way, while searching for the MACH_NEO1973 dependency, I found two
more files with problems:

- arch/arm/plat-s3c24xx/neo1973_pm_host.c is basically one huge #ifdef.
  This looks as if it wants to be included/excluded at the Makefile level.

- arch/arm/plat-s3c24xx/neo1973_shadow.c: has the wrong title comment and
  include/asm/plat-s3c24xx/neo1973.h should just
  #define neo1973_gpb_setpin s3c2410_gpio_setpin
  if not compiling for GTA02, and omit neo1973_shadow.o

  This logic will also need revisiting for the S3C24xx to generic GPIO
  change, which Ben says is becoming a requirement.

- Werner

More information about the openmoko-kernel mailing list