[PATCH] [GTA02]: Config fix for building without GTA01
werner at openmoko.org
Sun Oct 12 01:11:12 CEST 2008
Jonas Bonn wrote:
> This is nonsense, of course,
You mean it's nonsense because GTA02 is not a Neo1973 ?
In fact Neo1973 was meant to be used for both GTA01 and GTA02, and the
product naming only became less confusing long after the code was
So setting MACH_NEO1973 for GTA02 is correct in this context.
Whether we want to do a great purge that eliminates the Neo1973 name
and maybe the MACH_NEO1973 option entirely (*) is another question.
Personally, I find this kind of massive code change very scary, but
each time that historical accident causes some more confusion, the
Great Renaming feels a bit less evil ...
Andy, what do you think about this ? We would basically have to merge
all our branches into one before for such a major renaming, and then
stop all other kernel changes for a few days until the smoke settles.
(*) About the only place where removing MACH_NEO1973 would do more
than trivially change a single line is in
arch/arm/plat-s3c24xx/Makefile, and even there it's more wrong
than right (see my previous comment about neo1973_pm_host and
More information about the openmoko-kernel