[PATCH]: Cleanup of leds-neo1973

Werner Almesberger werner at openmoko.org
Tue Oct 14 21:15:19 CEST 2008

Nelson Castillo wrote:
> -MODULE_DESCRIPTION("FIC Neo1973 GTA02 LED driver");
> +MODULE_DESCRIPTION("FIC/Openmoko Neo1973 GTA02 LED driver");

Hmm, this is getting messy :-(

If we change those strings at all, then something like "Openmoko
GTA02" would be much closer to reality.

>  	if (vp->has_pwm)
> +	{


| The other issue that always comes up in C styling is the placement of
| braces.  Unlike the indent size, there are few technical reasons to
| choose one placement strategy over the other, but the preferred way, as
| shown to us by the prophets Kernighan and Ritchie, is to put the opening
| brace last on the line, and put the closing brace first, thusly:
|         if (x is true) {
|                 we do y
|         }

- Werner

More information about the openmoko-kernel mailing list