[PATCH]: Cleanup / stgnew
andy at openmoko.com
Wed Oct 15 18:39:38 CEST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
| On Wed, Oct 15, 2008 at 11:12 AM, Andy Green <andy at openmoko.com> wrote:
|> -----BEGIN PGP SIGNED MESSAGE-----
|> Hash: SHA1
|> Somebody in the thread at some point said:
|> | Remove unneeded spaces and coding style fixes. Purely cosmetic.
|> | I don't know if cleanup patches are wanted at the moment.
|> | I asked Andy for advise.
|> Yes they are welcome. Something else that won't take long but is
|> worthwhile and necessary is to collect all the warnings from a compile
|> and try to fix whatever it is. At the moment we have grown a dozen or
|> so that aren't killing us but won't be accepted anywhere upstream.
| I'm looking at the warnings right now. I Already fixed one that is a
| simple redefinition in arch/arm/plat-s3c24xx/pwm.c.
Great -- you also need to add "Signed-off-by: " on them.
Little hint for stgit... I have a few little scripts I made to increase
repeatability of certain things I found I messed up when my mind was
either exhausted or deeply involved with something complicated, I made
one script /usr/local/bin/stgnew
EMAIL="andy at openmoko.com"
if [ -z "$1" ] ; then
~ echo "Usage: $0 patch-name.patch"
~ exit 1
stg new --author "$NAME <$EMAIL>" --commname="$NAME"
- --commemail="$EMAIL" --sign --message="$PATCHNAME" $PATCHNAME
This takes care of the From, Signed-off-by and copies the patch name
into the first line of the patch description so it appears consistently
on gitweb, and it's even less characters than using stg new directly.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel