[UPSTREAM] Attempt at improving ADC access

Andy Green andy at openmoko.com
Thu Oct 16 01:18:50 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

| Also, don't the queue head/tail manipulation functions require locking ?

When I wrote them I recall coming to the idea that no locking is needed
because each of the "threads" only controls the head or the tail
exclusively.

| +		req = pcf->adc_queue[tail];
| +		WARN_ON(!pcf);

You might as well either BUG_ON() before it or just let it blow up on
NULL, it would blow up with a NULL OOPS even if the warning fired before.

- -Andy

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkj2eloACgkQOjLpvpq7dMpAIQCfdRykpJR0TkI2qxFFodcYF/Oa
JKsAn0M+prECjrJ/Ja9jeDNOhe9Jqz7l
=SMiK
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list