[PATCH 0/5]: Accelerometer refactoring and features

Andy Green andy at openmoko.com
Thu Oct 16 02:22:07 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

| Santa claus is back with a bag full of fresh bugs! This is a series of
| patches that refactor the accelerometer implementation a bit and adds
| some missing features. The series does this:

I confirmed it built and sent them on stable.

| * I've followed the convention of using __-prefixes in this file. I'm
|   not very happy about it myself, but it seems to be used for other
|   utility functions.

This is a good convention it seems to me, if you see __ it tells you to
start wondering where the locking is for this context.

| * Wakeups are like before: Configuring it to basically anything will
|   wake up the device immediately on suspend. I'm hoping this will be
|   fixed magically in 2.6.27

Doubt it will get magically fixed.  I think we find pcf50633 suspend
yanks the power to accels in suspend unless someone wrote some code to
take care about it when wake is enabled for accels.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkj2iSQACgkQOjLpvpq7dMq7EwCfTvHZRg6B1RbvV3IPfCs/1APg
/KkAoIa6KtrIxuW2kS5xz5Q0RguOFMWQ
=6r52
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list