[UPSTREAM] Attempt at improving ADC access
balajirrao at openmoko.org
Thu Oct 16 09:02:45 CEST 2008
On Thu, Oct 16, 2008 at 01:09:40AM -0200, Werner Almesberger wrote:
> Balaji Rao wrote:
> > Here's an attempt to improve ADC access in the pcf50633 driver.
> > I've introduced a method for synchronously reading from the ADC.
> Very nice work ! One suggestion for a slight simplification: you can
> avoid distinguishing synchronous and asynchronous by using a callback
> in adc_sync_read that does the completion.
Yea, I did that at one point, but tore it down later, for some reason I
don't recall. But It now looks like it can be done :)
Thanks for the review.
Now on to moving the charger stuff out of pcf50633.c..
More information about the openmoko-kernel