Fixing trivial warnings

Andy Green andy at openmoko.com
Thu Oct 16 10:54:12 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:

|> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c

|> +#if 0
|>        struct i2c_driver *driver;
|> +#endif

| The problem, as I see it, with this is that this file is coming from
| upstream.  The likely upstream fix will be to just delete these
| variables, not to comment them out.  When a patch comes down with
| these variables deleted then your patch won't apply as there will be
| incompatible changes across the two.

That's right, generally these warnings will disappear in a rebase or two
as the fix comes from upstream.  Since we're working quite close to
upstream HEAD, actually you can offer these patches directly upstream
yourself if you want to take a risk they are already fixed there
(although they will want you to delete it not #if 0 it as Jonas says).
Otherwise we should only take care about fixing the problems in our own
patchset.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkj3ATQACgkQOjLpvpq7dMoHJgCfV83/TT/9MEpED4JxPaIO3Q6h
4ZYAoIT2XigEiznCjop4goAdfmgka1gX
=0IFS
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list