[PATCH 0/8] Improve style of OM files

Nelson Castillo nelsoneci at gmail.com
Thu Oct 16 22:45:12 CEST 2008

On Thu, Oct 16, 2008 at 12:54 PM, Jonas Bonn <jonas.bonn at gmail.com> wrote:
>> The idea is to:
>> - Remove unwanted spaces
>> - Apply coding style fixes
>> - Modify strings for consistency, for instance replace "FIC Neo1073
>> GTA01" with "Openmoko GTA01".
>> - Fix one typo
> I don't necessarily agree with all these trivial whitespace changes.
> Two things bug me:
> i)  Much of it seems pretty arbitrary (and even inconsistent)...
> linebreaks and braces on if-statements, in particular.

Oh, I forgot to use the if {} else {} rule :-/ Sorry. Some old habits
are hard to forget.
For linebreaks I used the 80-chars rule.
I always make spaces visible. Misplaced spaces/tabs turn red in my
editor :-) I just hate them :-P

> PS:  No offense, Nelson.  The time you are investing in this is
> definitely appeciated... let's just get your time focussed on
> something more meaningful -- it's the best way to learn, really.  Hope
> the above list can be of some inspiration to you...

It's OK. My initial goal was to be comfortable with Stgit and I like it now.
As I've said before I'm getting ready for next month. Now I think I'd better
wait until then.


More information about the openmoko-kernel mailing list