[PATCH] *not for git* GTA01 - stop the SD card clock when idle
mwester at dls.net
Thu Oct 16 21:04:57 CEST 2008
Andy Green wrote:
> | I'll send in a properly formatted and signed off version once I get a
> | little feedback. Happy GPSing!
> I think we should put it on stable given it needs wide testing for
> something like GPS effect. It would let people get the "unstable"
> packages and really they can expect the odd problem there like broken
> SD, but it would get it wider audience.
> Since Jonas is looking at it if it is OK for him are you OK we just use it?
Habits die hard, I guess -- putting something on a stable branch when it
has only been tested by myself is something I am not accustomed to
doing. If Jonas (or any other person) can confirm that it at least
boots and doesn't trash the SD card, I'll immediately send in a formal
version of that patch (properly style-checked and all).
One question, as I review this code myself -- I put a spinlock to
protect the enable/disable of the clocks, but I'm not sure that has
turned out to be necessary. The register in question is never touched
inside the IRQ handler, so I think it is unnecessary. If someone can
confirm that it's safe to remove that spinlock, I'll clean that bit out.
More information about the openmoko-kernel