[PATCH] *not for git* GTA01 - stop the SD card clock when idle

Andy Green andy at openmoko.com
Fri Oct 17 10:40:48 CEST 2008

Hash: SHA1

Somebody in the thread at some point said:
| Andy Green wrote:
|> | I'll send in a properly formatted and signed off version once I get a
|> | little feedback.  Happy GPSing!
|> I think we should put it on stable given it needs wide testing for
|> something like GPS effect.  It would let people get the "unstable"
|> packages and really they can expect the odd problem there like broken
|> SD, but it would get it wider audience.
|> Since Jonas is looking at it if it is OK for him are you OK we just
use it?
| Habits die hard, I guess -- putting something on a stable branch when it
| has only been tested by myself is something I am not accustomed to
| doing.  If Jonas (or any other person) can confirm that it at least
| boots and doesn't trash the SD card, I'll immediately send in a formal
| version of that patch (properly style-checked and all).

Great, I see you did this and it is OK for Jonas.

Most of our users are taking packages from the stable branch of the
packaging stuff, that is already very conservative "downstream" of us.
If we are too cautious about what we put on kernel stable we will
fragment the test base of each of these branches to the point we're not
really testing what's in there anyway, just delaying it.  I had this
with stuff on andy branch that just sat there sometimes without
comment... it looks like QA but it isn't.

We can move faster this way with real staged QA from many users (taking
unstable feed) and it just means we have to be ready to revert or fix as
soon as we hear about trouble.

There's a nice "eyeball the patches" culture developing here too that is
really going to help.

| One question, as I review this code myself -- I put a spinlock to
| protect the enable/disable of the clocks, but I'm not sure that has
| turned out to be necessary.  The register in question is never touched
| inside the IRQ handler, so I think it is unnecessary.  If someone can
| confirm that it's safe to remove that spinlock, I'll clean that bit out.

Wow spin_lock_bh, certainly learning something new every day.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list