[PATCH 0/8] Improve style of OM files

Andy Green andy at openmoko.com
Fri Oct 17 10:57:07 CEST 2008

Hash: SHA1

Somebody in the thread at some point said:

|> PS:  No offense, Nelson.  The time you are investing in this is
|> definitely appeciated... let's just get your time focussed on
|> something more meaningful -- it's the best way to learn, really.  Hope
|> the above list can be of some inspiration to you...
| It's OK. My initial goal was to be comfortable with Stgit and I like
it now.

Ah great, it will definitely pay off.  Here is another script I use
(when I remember anyway) called /usr/local/bin/stgcheckpatch here



if [ -z "$1" ] ; then
~ stg refresh
~ PATCH=`stg top`
~ echo "*** checking top patch $PATCH"

stg export $PATCH && \
./scripts/checkpatch.pl patches-`stg branch`/$PATCH

with no argument it checks the top patch on the stack for kernel style
using ./scripts/checkpatch.pl, or you can have it check a named patch on
the stack.

| As I've said before I'm getting ready for next month. Now I think I'd
| wait until then.

OK... I think code cleaning is actually a good way to go through the
codebase getting the idea of how it hangs together, but actually the
kernel style takes a while to sink into the fingers, so ironically code
cleaning for style is not perfect task to start with.

Some of Jonas' ideas sound good, maybe the drivers/mmc/host/s3cmci.c
would make sense.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list