[PATCH] suppress "onkey" events on resume [Was: Re: Where are actions configured for buttons in FSO?]

Harald Welte laforge at openmoko.org
Fri Oct 17 11:21:05 CEST 2008

On Tue, Oct 14, 2008 at 05:52:02AM +0100, Andy Green wrote:
> Hash: SHA1
> Somebody in the thread at some point said:
> | Michael 'Mickey' Lauer wrote:
> | ...
> |> The problem is (and this is the reason why I'm crossposting this to the
> |> kernel mailing list), the kernel is not swallowing the power button
> |> presses that triggers the resume, so you need some "real" programming
> |> (as opposed to the expressional complexity of our rules) in order to
> |> prevent falling asleep right after resume.
> |>
> |> Kernel-guys, can we change that?
> |
> | suppress-resume-onkey-event.patch
> |
> | This suppresses the key press and key release events from the
> | power button, in the case where the power button is the wake
> | event for the GTA01 or GTA02 device.
> Nice work, thanks for taking the time to solve this.  Sent it on stable
> and stable-tracking.

I'm not actuall sure if this is the right thing to do.  After all, the ONKEY
was used (pressed and released) to resume the device.  I don't think this kind
of policy should belong into the kernel.  Userspace should deal with interpreting
when it wants to deal with ONKEY and when not.

- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
Software for the world's first truly open Free Software mobile phone

More information about the openmoko-kernel mailing list