[UPSTREAM] Move backlight handling out of pcf50633 driver
clinton at unknownlamer.org
Sun Oct 19 23:48:00 CEST 2008
"Mike (mwester)" <mwester at dls.net> writes:
>> As stated by
>> Andy, most software stacks use the sysfs value to get the
>> max_brightness. Tell us what breaks?
> No - if YOU want to change this, then YOU tell us why it WON'T break.
> Right now YOU represent ONLY YOUR user-space apps -- that's not adequate.
> And no, the fact is that the requirement to use max_brightness is NOT
> well known, or well documented -- and not all the distros use it.
> Should they? That's a different question.
> Just because you have excellent control over YOUR user space does not
> entitle you or Om to make this sort of change with ONLY your input!
> Other existing distros, ESPECIALLY the ones that actually out in common
> use (!) should also be considered.
>> If it is new code, why not check
> Yes, ****NEW*** code should do this. But hey! News flash! There is
> EXISTING code for these devices, and it doesn't do that!!! It's
> unfortunate that I seem to be the only one advocating for that community...
If the existing code does not check max_brightness then it is
*broken*. There is no reason to ensure that fundamentally broken code
continues to run.
Who will tend the garden when the snake swallows the light?
Who will eat the decay when the worms have lost their sight?
Who will rape the weak when there's nothing left to gain?
Who will till the soil of these barren black remains?
More information about the openmoko-kernel