[UPSTREAM] Move backlight handling out of pcf50633 driver

Werner Almesberger werner at openmoko.org
Mon Oct 20 09:51:11 CEST 2008

Sean McNeil wrote:
> This is the best reasoning I've seen to leave the value as-is.

Thanks :-)

> I still wouldn't mind a #define so it can be  
> adjusted in the kernel in 1 place if necessary,

I guess that bit of extra complexity wouldn't hurt too much.

However, you have to decide on what you do when reading back values.
I.e., do you read back the real value from the chip and scale it, or
do you introduce a shadow register to read back what you last wrote ?

Even those small things have a tendency of getting tricky if you let
them ...

- Werner

More information about the openmoko-kernel mailing list