[UPSTREAM] Use new regulator API for pcf50633

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Oct 28 16:22:28 CET 2008


On Tue, Oct 28, 2008 at 03:04:27PM +0000, Liam Girdwood wrote:
> On Tue, 2008-10-28 at 20:22 +0530, Balaji Rao wrote:

> > Yes, exaclty! Suppose we assume that the driver is compiled in, can we
> > guarantee that ? 

Currently.  Might change in future but I'd not consider it likely.

> They _should_ be built in (and were when I last worked on the WM8350). I
> missed this in the patch submission. A regulator driver should be marked
> bool in it's Kconfig and should be registered before any of it's
> consumers in board.c.

> Fwiw, we did use tristate for regulators to aid in development.

If you provide a pcf50633_register_regulator() type function then there
will be link errors for users who don't get this right by doing
something like select the regulator driver.



More information about the openmoko-kernel mailing list