[UPSTREAM PATCH] pm_gps_use_regulator_api.patch

Balaji Rao balajirrao at openmoko.org
Wed Oct 29 20:10:06 CET 2008


On Wed, Oct 29, 2008 at 04:54:00PM -0200, Werner Almesberger wrote:
> Balaji Rao wrote:
> > +		if ((on) && (!neo1973_gps.power_was_on))
> > +			regulator_enable(neo1973_gps.regulator);
> > +
> > +		if ((!on) && (neo1973_gps.power_was_on))
> > +			regulator_disable(neo1973_gps.regulator);
> 
> They won't change operator precedence in GCC anytime soon :-)
> Doesn't this look a lot less intimidating ?
> 
> > +		if (on && !neo1973_gps.power_was_on)
> ...
> > +		if (!on && neo1973_gps.power_was_on)
> 

Yes, really! I wonder how did it get in there! Will change :)

	- Balaji



More information about the openmoko-kernel mailing list