[UPSTREAM PATCH] remove_pcf50633_voltage_rails_and_friends.patch

Balaji Rao balajirrao at openmoko.org
Fri Oct 31 14:16:04 CET 2008


On Fri, Oct 31, 2008 at 10:30:18AM -0200, Werner Almesberger wrote:
> Balaji Rao wrote:
> > 4. Removes on-during-standby flag from auto1 and down2 convertors. Specs say
> >    they are turned off during standby.
> 
> Hmm, do you mean PMU_VRAIL_F_SUSPEND_ON ? That would be for suspend
> (as in "suspend/resume"), not what the PMU calls "Standby".
> 
> PMU.Standby is in fact when the system is turned off.
> 

Right. I thought that the PMU will be taken to standby mode when we
suspend. But seeing the code now, it's not.

> Did suspend/resume actually work with this change ? If yes, that
> would be rather interesting ...
> 

It did work though. OK. I know the problem. My bad. My understanding
that the pmu will be put to standby when we suspend is fundamentally
wrong! 

That's brings one question to my mind. Why do we need to save the
registers that don't "survive" standby (a comment in pcf50633_suspend
says so), if we are not going into standby at all ? Please explain.

	- Balaji



More information about the openmoko-kernel mailing list