[PATCH] gta03-pca9632.patch (#2 submit)
matt_hsu at openmoko.org
Thu Sep 18 14:01:53 CEST 2008
Andy Green wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Somebody in the thread at some point said:
> | Not sure I understood this, the patch just provides the driver and does
> | not create platform data instance, in initdata or elsewhere? It's OK if
> | we can't put any platform data in initdata because we use it directly,
> | we do that in other drivers already.
> |> You are right,
> |> /* FIXME: platform data should be attached here */
> |> + pca9632_pdev = pdev
> |> I was thinking about this note and maybe add few comments.
> |> I'm sorry :(
The patch here I don't attach any platform data since the profile of LED
blinking/dimming specific to gta03 is not decided.
It's product design related.
Any concerns or feedback would be good to us.
> No trouble, I am very happy if someone is reading the patches here.
> Don't hesitate to say again if you think you see something.
> I sent Matt's patch on stable.
> - -Andy
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
> -----END PGP SIGNATURE-----
More information about the openmoko-kernel